On Fri, Jan 19, 2007 at 11:56:30AM -0500, Robert P. J. Day wrote:
>
> Remove the macros that define simple "inlining" to mean forced
> inlining, since you can (and *should*) get that effect with the
> CONFIG_FORCED_INLINING kernel config variable instead.
NAK.
I don't see any place in the kernel where we need a non-forced inline.
We have tons of inline's in C files that should simply be removed -
let's do this instead.
> Signed-off-by: Robert P. J. Day <[email protected]>
>
> ---
>
> this change was compile tested on x86 with "make allyesconfig",
> followed by turning off forced inlining.
>
> now the alpha folks can simplify their compiler.h file. :-)
>
>
> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> index 6e1c44a..5a90bd9 100644
> --- a/include/linux/compiler-gcc.h
> +++ b/include/linux/compiler-gcc.h
> @@ -23,9 +23,6 @@
> (typeof(ptr)) (__ptr + (off)); })
>
>
> -#define inline inline __attribute__((always_inline))
> -#define __inline__ __inline__ __attribute__((always_inline))
> -#define __inline __inline __attribute__((always_inline))
> #define __deprecated __attribute__((deprecated))
> #define noinline __attribute__((noinline))
> #define __attribute_pure__ __attribute__((pure))
Oh, and your patch would have been broken for gcc < 4.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
