Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

On Thu, Jan 18, 2007 at 02:13:39PM -0500, Benjamin Romer wrote:
[..]
> > >
> > > OK, here's the updated patch that uses the new definition and fixes up
> > > the other places that use it. I built and tested this on the ES7000/ONE
> > > and it works well. :)
> >
> > Cool.
> >
> > I hate to pick nits by why the double underscore on dest?
> >
> 
> It was defined that way in the updated structure definition you sent in
> a previous mail, so I figured you wanted it that way. Here's another
> revision with the double underscores removed. :)
> 
> -- Ben
> 

This patch looks good to me. You might want to provide some description
too for changelog.

Thanks
Vivek
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)
    • From: Benjamin Romer <[email protected]>

• References:
  • PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)
    • From: Benjamin Romer <[email protected]>
  • Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)
    • From: [email protected] (Eric W. Biederman)
  • Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)
    • From: Vivek Goyal <[email protected]>
  • Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)
    • From: Vivek Goyal <[email protected]>
  • Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)
    • From: [email protected] (Eric W. Biederman)
  • Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)
    • From: Vivek Goyal <[email protected]>
  • Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)
    • From: Benjamin Romer <[email protected]>
  • Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)
    • From: [email protected] (Eric W. Biederman)
  • Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)
    • From: Benjamin Romer <[email protected]>

• Prev by Date: Re: Ext3 mounted as ext2 but journal still in effect.
• Next by Date: Re: [PATCH] Make CARDBUS_MEM_SIZE and CARDBUS_IO_SIZE customizable
• Previous by thread: Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)
• Next by thread: Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]