Re: [PATCH] Fix compile warnings in r8169

Bernhard Walle <[email protected]> :
> --- linux-2.6.20-rc4.orig/drivers/net/r8169.c	2007-01-07 06:45:51.000000000 +0100
> +++ linux-2.6.20-rc4/drivers/net/r8169.c	2007-01-17 11:39:13.792309228 +0100
[...]
> @@ -2227,7 +2227,7 @@ static int rtl8169_xmit_frags(struct rtl
>  {
>  	struct skb_shared_info *info = skb_shinfo(skb);
>  	unsigned int cur_frag, entry;
> -	struct TxDesc *txd;
> +	struct TxDesc *txd = NULL;
>  
>  	entry = tp->cur_tx;
>  	for (cur_frag = 0; cur_frag < info->nr_frags; cur_frag++) {

The driver is right. This change does not alleviate the maintenance
of the driver nor does it add incentive to fix the compiler.

-- 
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Fix compile warnings in r8169
    • From: Bernhard Walle <[email protected]>

• Prev by Date: Re: [linux-usb-devel] 2.6.20-rc5: BUG: lock held at task exit time! (pm_mutex){--..}, at: [<c013bfff>] enter_state+0x3f/0x170
• Next by Date: Re: "obsolete" versus "deprecated", and a new config option?
• Previous by thread: [PATCH] Fix compile warnings in r8169
• Next by thread: [PATCH] Introduce and use get_task_mnt_ns()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]