Re: [PATCH 45/59] sysctl: C99 convert ctl_tables in drivers/parport/procfs.c

Hi Eric,

On Tuesday, 16. January 2007 17:39, Eric W. Biederman wrote:
> diff --git a/drivers/parport/procfs.c b/drivers/parport/procfs.c
> index 2e744a2..5337789 100644
> --- a/drivers/parport/procfs.c
> +++ b/drivers/parport/procfs.c
> @@ -263,50 +263,118 @@ struct parport_sysctl_table {
> +		{
> +			.ctl_name	= DEV_PARPORT_BASE_ADDR,
> +			.procname	= "base-addr",
> +			.data		= NULL,
> +			.maxlen		= 0,
> +			.mode		= 0444,
> +			.proc_handler	= &do_hardware_base_addr
> +		},

No need to initialize to zero or NULL. Just list any variable, which is NOT zero or NULL.

> +		{
> +			.ctl_name	= DEV_PARPORT_AUTOPROBE + 1,
> +			.procname	= "autoprobe0",
> +			.data		= NULL,
> +			.maxlen		= 0,
> +			.maxlen		= 0444,
> +			.proc_handler	=  &do_autoprobe
> +		},

Typo here? .mode = 0444 makes mor sense.

Regards

Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 45/59] sysctl: C99 convert ctl_tables in drivers/parport/procfs.c
    • From: [email protected] (Eric W. Biederman)

• References:
  • [PATCH 0/59] Cleanup sysctl
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 45/59] sysctl: C99 convert ctl_tables in drivers/parport/procfs.c
    • From: "Eric W. Biederman" <[email protected]>

• Prev by Date: [PATCH] nfs: fix congestion control
• Next by Date: Re: [RFC 0/8] Cpuset aware writeback
• Previous by thread: [PATCH 45/59] sysctl: C99 convert ctl_tables in drivers/parport/procfs.c
• Next by thread: Re: [PATCH 45/59] sysctl: C99 convert ctl_tables in drivers/parport/procfs.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]