Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros

• To: Greg KH <[email protected]>
• Subject: Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros
• From: "Ahmed S. Darwish" <[email protected]>
• Date: Mon, 15 Jan 2007 11:17:28 +0200
• Cc: [email protected], [email protected]
• Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:to:cc:subject:message-id:mail-followup-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent:from; b=DC0SEnQwXDpL3AWDxB9TDX2YWefS4dJHKUIm4OJYHfyajLOQRCZJWG4dFolypZmVSGQ0hCq4Rqd07RpzbPuKbk421zH/gPzqexXwYLwpkWFQAjwFMDZpgNxhHxpf50a93xL7/z5zK7J/CdFSP7issdl1o7QGryV912VRZuN3IMQ=
• In-reply-to: <[email protected]>
• Mail-followup-to: Greg KH <[email protected]>, [email protected], [email protected]
• References: <20070114172421.GA3874@Ahmed> <[email protected]>
• Sender: [email protected]
• User-agent: Mutt/1.5.11

On Sun, Jan 14, 2007 at 04:29:48PM -0800, Greg KH wrote:
> On Sun, Jan 14, 2007 at 07:24:21PM +0200, Ahmed S. Darwish wrote:
> > Substitue intel_rng magic PCI IDs values used in the IDs table
> > with the macros defined in pci_ids.h
> 
> Why not use the PCI_DEVICE() macro too?  It should make the lines even
> smaller.

Ooh yes, I forgot about this macro.
Updating the patch. Thanks :).

-- 
Ahmed S. Darwish
http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros
    • From: "Ahmed S. Darwish" <[email protected]>
  • Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros
    • From: Greg KH <[email protected]>

• Prev by Date: [PATCH 1/1] Fix a panic while mouting containers on powerpc and some other small cleanups (Re: [ckrm-tech] [PATCH 4/6] containers: Simple CPU accounting container subsystem)
• Next by Date: Re: [PATCH] Fix __ucmpdi2 in v4l2_norm_to_name()
• Previous by thread: Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros
• Next by thread: Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]