Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros

On 1/15/07, Arjan van de Ven <[email protected]> wrote:

On Sun, 2007-01-14 at 19:24 +0200, Ahmed S. Darwish wrote:
> Substitue intel_rng magic PCI IDs values used in the IDs table
> with the macros defined in pci_ids.h
>
Hi,


hmm this is actually the opposite direction than most of the kernel is
heading in, mostly because the pci_ids.h file is a major maintenance
pain.

Afaik the current "rule" is: if a PCI ID is only used in one driver, use
the numeric value and not (add) a symbolic constant.

My guess is that the RNG is on the LPC so the values are used in a few places..

Dave.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros
    • From: "Ahmed S. Darwish" <[email protected]>

• References:
  • [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros
    • From: "Ahmed S. Darwish" <[email protected]>
  • Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros
    • From: Arjan van de Ven <[email protected]>

• Prev by Date: [patch] netfilter: implement TCPMSS target for IPv6
• Next by Date: Re: O_DIRECT question
• Previous by thread: Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros
• Next by thread: Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]