Re: [patch 20/20] XEN-paravirt: Add Xen virtual block device driver.

On Sat, Jan 13, 2007 at 05:07:28PM -0800, Arjan van de Ven wrote:
> > +
> > +#define DPRINTK(_f, _a...) pr_debug(_f, ## _a)
> 
> why this silly abstraction? Just use pr_debug in the code directly

Actually, for drivers, like this one, you should use the dev_printk()
and friends (dev_dbg, dev_err, etc.) instead so that userspace knows
exactly which device and driver the message comes from.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch 00/20] XEN-paravirt: Xen guest implementation for paravirt_ops interface
    • From: Jeremy Fitzhardinge <[email protected]>
  • [patch 20/20] XEN-paravirt: Add Xen virtual block device driver.
    • From: Jeremy Fitzhardinge <[email protected]>
  • Re: [patch 20/20] XEN-paravirt: Add Xen virtual block device driver.
    • From: Arjan van de Ven <[email protected]>

• Prev by Date: Re: No more "device" symlinks for classes
• Next by Date: Re: Display class
• Previous by thread: Re: [patch 20/20] XEN-paravirt: Add Xen virtual block device driver.
• Next by thread: Re: [Xen-devel] Re: [patch 20/20] XEN-paravirt: Add Xen virtual block device driver.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]