[PATCH 4/5] KVM: Fix asm constraints with CONFIG_FRAME_POINTER=n

A "g" constraint may place a local variable in an %rsp-relative memory operand.
but if your assembly changes %rsp, the operand points to the wrong location.

An "r" constraint fixes that.

Thanks to Ingo Molnar for neatly bisecting the problem.

Signed-off-by: Avi Kivity <[email protected]>

Index: linux-2.6/drivers/kvm/vmx.c
===================================================================
--- linux-2.6.orig/drivers/kvm/vmx.c
+++ linux-2.6/drivers/kvm/vmx.c
@@ -1825,7 +1825,7 @@ again:
 #endif
 		"setbe %0 \n\t"
 		"popf \n\t"
-	      : "=g" (fail)
+	      : "=r" (fail)
 	      : "r"(vcpu->launched), "d"((unsigned long)HOST_RSP),
 		"c"(vcpu),
 		[rax]"i"(offsetof(struct kvm_vcpu, regs[VCPU_REGS_RAX])),
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 4/5] KVM: Fix asm constraints with CONFIG_FRAME_POINTER=n
    • From: Herbert Xu <[email protected]>

• References:
  • [PATCH 0/5] KVM updates for 2.6.20
    • From: Avi Kivity <[email protected]>

• Prev by Date: [PATCH 3/5] KVM: x86 emulator: fix bit string instructions
• Next by Date: [PATCH 5/5] KVM: Fix bogus pagefault on writable pages
• Previous by thread: [PATCH 3/5] KVM: x86 emulator: fix bit string instructions
• Next by thread: Re: [PATCH 4/5] KVM: Fix asm constraints with CONFIG_FRAME_POINTER=n
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]