Re: [patch -mm] slab: use CPU_LOCK_[ACQUIRE|RELEASE]

On Tue, 9 Jan 2007, Heiko Carstens wrote:

> -	case CPU_UP_PREPARE:
> +	case CPU_LOCK_ACQUIRE:
>  		mutex_lock(&cache_chain_mutex);
> +		break;

I have got a bad feeling about upcoming deadlock problems when looking at 
the mutex_lock / unlock code in cpuup_callback in slab.c. Branches 
that just obtain a lock or release a lock? I hope there is some 
control of  what happens between lock acquisition and release?

You are aware that this lock is taken for cache shrinking/destroy, tuning 
of cpu cache sizes, proc output and cache creation? Any of those run on 
the same processor should cause a deadlock.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch -mm] slab: use CPU_LOCK_[ACQUIRE|RELEASE]
    • From: Srivatsa Vaddagiri <[email protected]>

• References:
  • Failure to release lock after CPU hot-unplug canceled
    • From: Benjamin Gilbert <[email protected]>
  • Re: Failure to release lock after CPU hot-unplug canceled
    • From: Heiko Carstens <[email protected]>
  • Re: Failure to release lock after CPU hot-unplug canceled
    • From: Srivatsa Vaddagiri <[email protected]>
  • Re: Failure to release lock after CPU hot-unplug canceled
    • From: Heiko Carstens <[email protected]>
  • [patch -mm] slab: use CPU_LOCK_[ACQUIRE|RELEASE]
    • From: Heiko Carstens <[email protected]>

• Prev by Date: Re: SATA/IDE Dual Mode w/Intel 945 Chipset or HOW TO LIQUIFY a flash IDE chip under 2.6.18
• Next by Date: Re: macros: "do-while" versus "({ })" and a compile-time error
• Previous by thread: [patch -mm] slab: use CPU_LOCK_[ACQUIRE|RELEASE]
• Next by thread: Re: [patch -mm] slab: use CPU_LOCK_[ACQUIRE|RELEASE]
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]