Re: ntp.c : possible inconsistency?

> Without a further explanation of this craziness, it's a little hard to
> discuss...
Let's try it:
time_constant is created for internal use of ntp.c and added by 4
-               time_constant = min(txc->constant + 4, (long)MAXTC);
+               time_constant = min(txc->constant + 4, (long)MAXTC + 4);

But sometimes it is written back to data referenced from outside. So let's do 
the + 4 backwards ...
-       txc->constant      = time_constant;
+       txc->constant      = time_constant - 4;

otherwise I'd like to speak of an inconsistency. It doesn't depend of actual 
use and other topics.

Bernhard
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: ntp.c : possible inconsistency?
    • From: Roman Zippel <[email protected]>

• References:
  • ntp.c : possible inconsistency?
    • From: Bernhard Schiffner <[email protected]>
  • Re: ntp.c : possible inconsistency?
    • From: Roman Zippel <[email protected]>

• Prev by Date: Re: "svc: unknown version (3)" when CONFIG_NFSD_V4=y
• Next by Date: Re: 2.6.20-rc4: null pointer deref in khubd
• Previous by thread: Re: ntp.c : possible inconsistency?
• Next by thread: Re: ntp.c : possible inconsistency?
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]