RE: [PATCH] x86_64 ioapic: check_timer_pin Don't add_pin_to_irq if it is already there.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-----Original Message-----
From: [email protected] [mailto:[email protected]] 
Sent: Monday, January 08, 2007 2:50 PM
To: Andrew Morton
Cc: Linus Torvalds; Tobias Diedrich; Adrian Bunk; Andi Kleen; Linux
Kernel Mailing List; Lu, Yinghai
Subject: [PATCH] x86_64 ioapic: check_timer_pin Don't add_pin_to_irq if
it is already there.

>Yep.  My oversight.  Here is the trivial patch to fix it.  I don't
>see how we could hit this case but if we are going to allow for it
>we should handle it correctly.

Yes, in your check_timer calling sequence, at that point irq can not be
0.
( remove_irq_to_pin already remove that entry).

Or in check_timer_pin

+	if ((irq != -1) && (irq != 0)) {

==>

+	if (irq != -1) {

YH



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux