Alan wrote:
The problem you need to fix or work around is ata_probe_ent, which
doesn't properly fill in ata_port info for this situation. Tejun has
posted patches that kill ata_probe_ent, which you were pointed to.
And which are not yet in the main tree leaving many users unable to
install Linux.
The controllers affected by your patch have been around for well over a
year. I doubt a huge amount of suffering will be caused by pausing to
get it right... especially when you have been pointed at two working
code examples that already get it right.
This isn't the way to get stuff done. When you've got the
new patches in the driver can use them if its worth it (which, see below,
I question).
In Linux, we work /with/ the subsystem, not around it.
Your current approach is fundamentally flawed. You can see this because
e.g. a call to vt6421_ops::scr_read() will immediately oops, after your
patch.
Just separate PATA and SATA operations. That way everything works as
expected, and you don't unintentionally add lovely oopses all over the
place.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
