Re: [PATCH] include/linux/slab.h: new KFREE() macro.

--- Sumit Narayan <[email protected]> wrote:

> Asking for KFREE is as silly as asking for a macro to check if kmalloc
> succeeded for a pointer, else return ENOMEM.
> 
> #define CKMALLOC(p,x) \
>    do {   \
>        p = kmalloc(x, GFP_KERNEL); \
>        if(!p) return -ENOMEM; \
>     } while(0)
> 

There are bugs with this approach. This introduces error path leaks. If you have allocated some
memory earlier, then you got to free them.

-Amit

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [PATCH] include/linux/slab.h: new KFREE() macro.
    • From: "Sumit Narayan" <[email protected]>

• Prev by Date: Re: [PATCH 2.6.20-rc3] sata_promise: ATAPI support
• Next by Date: RE: [PATCH] include/linux/slab.h: new KFREE() macro.
• Previous by thread: Re: [PATCH] include/linux/slab.h: new KFREE() macro.
• Next by thread: Re: [PATCH] include/linux/slab.h: new KFREE() macro.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]