Hi Kyle, Looks good. Just one nit and one comment. On Sun, 7 Jan 2007 10:40:45 -0500 Kyle McMartin <[email protected]> wrote: > > diff --git a/kernel/compat.c b/kernel/compat.c > index 6952dd0..cebb4c2 100644 > --- a/kernel/compat.c > +++ b/kernel/compat.c . . . > + __put_user (s.uptime, &info->uptime) || ^ We don't put spaces in here ... > +asmlinkage long sys_sysinfo(struct sysinfo __user *info) > +{ > + struct sysinfo val; > + > + do_sysinfo(&val); > > - out: > if (copy_to_user(info, &val, sizeof(struct sysinfo))) > return -EFAULT; People have complined before that this adds a whole stack frame to the "normal" syscall path. Personally I don't care, but it has been mentioned. -- Cheers, Stephen Rothwell [email protected] http://www.canb.auug.org.au/~sfr/
Attachment:
pgpCWzEp4lNkn.pgp
Description: PGP signature
- Follow-Ups:
- Re: [PATCH] Common compat_sys_sysinfo (v2)
- From: Arnd Bergmann <[email protected]>
- Re: [PATCH] Common compat_sys_sysinfo (v2)
- References:
- [PATCH] Common compat_sys_sysinfo
- From: Kyle McMartin <[email protected]>
- Re: [PATCH] Common compat_sys_sysinfo
- From: Christoph Hellwig <[email protected]>
- Re: [PATCH] Common compat_sys_sysinfo
- From: Kyle McMartin <[email protected]>
- [PATCH] Common compat_sys_sysinfo (v2)
- From: Kyle McMartin <[email protected]>
- [PATCH] Common compat_sys_sysinfo
- Prev by Date: Re: OT: character encodings (was: Linux 2.6.20-rc4)
- Next by Date: Re: 2.6.20-rc3 regression: suspend to RAM broken on Mac mini Core Duo
- Previous by thread: [PATCH] Common compat_sys_sysinfo (v2)
- Next by thread: Re: [PATCH] Common compat_sys_sysinfo (v2)
- Index(es):
 |