Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update

On 01/07, Oleg Nesterov wrote:
>
> Thoughts?

How about:

	CPU_DEAD does nothing. After __cpu_disable() cwq->thread runs on
	all CPUs and becomes idle when it flushes cwq->worklist: nobody
	will add work_struct on that list.

	CPU_UP:
		if (!cwq->thread)
			create_workqueue_thread();
		else
			set_cpus_allowed(newcpu);

	flush_workqueue:
		for_each_possible_cpu()		// NOT online!
			if (cwq->thread)
				flush_cpu_workqueue()

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
    • From: Srivatsa Vaddagiri <[email protected]>
  • Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
    • From: Oleg Nesterov <[email protected]>

• References:
  • Re: [PATCH, RFC] reimplement flush_workqueue()
    • From: Srivatsa Vaddagiri <[email protected]>
  • Re: [PATCH, RFC] reimplement flush_workqueue()
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH, RFC] reimplement flush_workqueue()
    • From: Andrew Morton <[email protected]>
  • [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
    • From: Srivatsa Vaddagiri <[email protected]>
  • Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
    • From: Srivatsa Vaddagiri <[email protected]>
  • Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
    • From: Srivatsa Vaddagiri <[email protected]>
  • Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
    • From: Oleg Nesterov <[email protected]>

• Prev by Date: Re: Multi kernel tree support on the same distro?
• Next by Date: Re: Linux 2.6.20-rc4
• Previous by thread: Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
• Next by thread: Re: [PATCH] fix-flush_workqueue-vs-cpu_dead-race-update
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]