Re: [PATCH] qconf: fix SIGSEGV on empty menu items

Roman Zippel wrote on 06-01-07 04:20:

<snip>

Thanks, but this is more complex than necessary.
It simply lacks some initializers.

<snip>

---
Index: linux-2.6/scripts/kconfig/qconf.cc
===================================================================
--- linux-2.6.orig/scripts/kconfig/qconf.cc	2007-01-05 01:47:54.000000000 +0100
+++ linux-2.6/scripts/kconfig/qconf.cc	2007-01-05 01:56:54.000000000 +0100
@@ -915,7 +915,7 @@ void ConfigView::updateListAll(void)
 }

ConfigInfoView::ConfigInfoView(QWidget* parent, const char *name)

-	: Parent(parent, name), menu(0)
+	: Parent(parent, name), menu(0), sym(0)
 {
 	if (name) {
 		configSettings->beginGroup(name);
@@ -951,6 +951,7 @@ void ConfigInfoView::setInfo(struct menu
 	if (menu == m)
 		return;
 	menu = m;
+	sym = NULL;
 	if (!menu)
 		clear();
 	else
-

I can confirm that this patch squashed the segfault.

bjd


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] qconf: fix SIGSEGV on empty menu items
    • From: "Cyrill V. Gorcunov" <[email protected]>
  • Re: [PATCH] qconf: fix SIGSEGV on empty menu items
    • From: Roman Zippel <[email protected]>

• Prev by Date: sysrq_always_enabled boot option ??
• Next by Date: Re: asynchronous memory transfer/transform api(s) (was: Re: [RFC] Heads up on a series of AIO patchsets)
• Previous by thread: Re: [PATCH] qconf: fix SIGSEGV on empty menu items
• Next by thread: [PATCH -mm] integrity: don't return a value from void function
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]