Re: [PATCH 2.6.20-rc3] TTY_IO: Remove unnecessary kmalloc casts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 05, 2007 at 11:26:07AM +0100, Rolf Eike Beer wrote:

> One big patch for the whole kernel will not work anyway. You have to split it 
> up to allow subsystems to integrate them in their own trees. With one big 
> patch you would get collisions all over the tree causing the complete patch 
> to get dropped. Also CC subsystem maintainers on their parts. And please send 
> the patches as replies to the first one as it cleans up readability of lkml a 
> lot :)

Oops, Just read this warning after sending the (big) patch. Sorry It's my first
patch :). I'll split it and do as written. Thanks alot :).

> > I think this will be better done in another patch to let every patch do one
> > single thing. right ?
> 
> Yes. But I would suggest starting with the kmalloc()->kzalloc() things. When 
> you do this conversions just remove the casts of the lines you're touching. 
> This will reduce the size of the complete thing avoiding two rather trivial 
> patches touching the same line twice.
> 
> Eike

OK. In progress

-- 
Ahmed S. Darwish
http://darwish-07.blogspot.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux