Re: [PATCH] fix BUG_ON(!PageSlab) from fallback_alloc

Hi Hugh,

[Sorry, no access to kernel tree right now, so can't send a patch.]

On 1/4/07, Hugh Dickins <[email protected]> wrote:

@@ -3310,7 +3310,7 @@ retry:
                                         */
                                        goto retry;
                        } else {
-                               kmem_freepages(cache, obj);
+                               /* cache_grow already freed obj */
                                obj = NULL;

So, how about we rename the current cache_grow() to __cache_grow() and
move the kmem_freepages() to a higher level function like this:

static int cache_grow(struct kmem_cache *cache,
                               gfp_t flags, int nodeid)
{
       void *objp;
       int ret;

       if (flags & __GFP_NO_GROW)
               return 0;

       objp = kmem_getpages(cachep, flags, nodeid);
       if (!objp)
               return 0;

       ret = __cache_grow(cache, flags, nodeid, objp);
       if (!ret)
               kmem_freepages(cachep, objp);

       return ret;
}

And use the non-allocating __cache_grow version() in fallback_alloc() instead?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] fix BUG_ON(!PageSlab) from fallback_alloc
    • From: Hugh Dickins <[email protected]>
  • Re: [PATCH] fix BUG_ON(!PageSlab) from fallback_alloc
    • From: Christoph Lameter <[email protected]>

• References:
  • [PATCH] fix BUG_ON(!PageSlab) from fallback_alloc
    • From: Hugh Dickins <[email protected]>

• Prev by Date: Re: PROBLEM: sata_sil24 lockups under heavy i/o
• Next by Date: Re: [UPDATED PATCH] fix memory corruption from misinterpreted bad_inode_ops return values
• Previous by thread: [PATCH] fix BUG_ON(!PageSlab) from fallback_alloc
• Next by thread: Re: [PATCH] fix BUG_ON(!PageSlab) from fallback_alloc
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]