Re: [PATCH 2.6.19 1/2] X.25: Adds call forwarding to X.25

> +	struct sk_buff *skbn;
> +	skbn = skb_clone(skb, GFP_ATOMIC);
> +

If this fails then you starting passing NULL around. I'm also a bit
confused as to where you free the copy in all the error cases ?

Is there any reason for creating skbn here rather than in
skb_forward_call ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH 1/3] [RESEND] X.25: Add call forwarding
    • From: ahendry <[email protected]>

• References:
  • [PATCH 2.6.19 1/2] X.25: Adds call forwarding to X.25
    • From: ahendry <[email protected]>

• Prev by Date: Re: [nfsv4] RE: Finding hardlinks
• Next by Date: Re: [PATCH] X.25: Trivial, SOCK_DEBUG's in x25_facilities missing newlines
• Previous by thread: [PATCH 2.6.19 1/2] X.25: Adds call forwarding to X.25
• Next by thread: [PATCH 1/3] [RESEND] X.25: Add call forwarding
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]