Re: [PATCH 2.6.20-rc2] [BUGFIX] drivers/atm/firestream.c: Fix infinite recursion when alignment passed is 0.

• To: "Mitchell Blank Jr" <[email protected]>
• Subject: Re: [PATCH 2.6.20-rc2] [BUGFIX] drivers/atm/firestream.c: Fix infinite recursion when alignment passed is 0.
• From: "Pekka Enberg" <[email protected]>
• Date: Thu, 4 Jan 2007 09:29:55 +0200
• Cc: "Amit Choudhary" <[email protected]>, "Linux Kernel" <[email protected]>, [email protected]
• Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=fAM0c8RNRxxdZTo9fXdhrZKmgStoDRKPvD9WuI+2cTxKygrEnAGRlTjAmVv98S0DdYvNWlo65ohUaodpkxy9AnDf6WvIlYfyOBQNtOj9Ca/zUB2xbNtpMTBHv47Ws1ZgnaAPmnvCAnlwS3YoBsLHjGFrLhFOKa4dGscqcCRqAlA=
• In-reply-to: <[email protected]>
• References: <[email protected]> <[email protected]>
• Sender: [email protected]

On 12/31/06, Mitchell Blank Jr <[email protected]> wrote:

Looking at aligned_kmalloc() it seems to be pretty badly broken -- its fallback
if it gets a non-aligned buffer is to just try a larger size which doesn't
necessarily fix the problem.  It looks like explicitly aligning the buffer
is a better solution.

Shouldn't we be using dma_alloc_*() here instead of abusing kmalloc()?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Prev by Date: Re: VM: Fix nasty and subtle race in shared mmap'ed page writeback
• Next by Date: Re: [PATCH 2.6.19] mmc: Add support for SDHC cards (Take 2)
• Previous by thread: Re: [PATCH 2.6.20-rc2] [BUGFIX] drivers/atm/firestream.c: Fix infinite recursion when alignment passed is 0.
• Next by thread: [PATCH 2.6.19 1/2] X.25: Adds call forwarding to X.25
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]