Re: [patch] aio: make aio_ring_info->nr_pages an unsigned int

--- ./include/linux/aio.h.orig	2006-12-24 22:31:55.000000000 -0800
+++ ./include/linux/aio.h	2006-12-24 22:41:28.000000000 -0800
@@ -165,7 +165,7 @@ struct aio_ring_info {

 	struct page		**ring_pages;
 	spinlock_t		ring_lock;
-	long			nr_pages;
+	unsigned		nr_pages;

 	unsigned		nr, tail;

Hmm.

This seems so trivial as to not be worth it. It'd be more compelling if it was more thorough -- doing things like updating the 'long i' iterators that a feww have over ->nr_pages. That kind of thing. Giving some confidence that the references of ->nr_pages were audited.

- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • RE: [patch] aio: make aio_ring_info->nr_pages an unsigned int
    • From: "Chen, Kenneth W" <[email protected]>

• Prev by Date: Re: [PATCH] Open Firmware device tree virtual filesystem
• Next by Date: RE: [patch] aio: add per task aio wait event condition
• Previous by thread: Re: [patch] aio: remove spurious ring head index modulo info->nr
• Next by thread: RE: [patch] aio: make aio_ring_info->nr_pages an unsigned int
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]