Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?

On Mon, Jan 01, 2007 at 05:27:10AM -0500, Robert P. J. Day wrote:

 > > both look good... I'd be in favor of this. Maybe also add a part
 > > about using GFP_KERNEL whenever possible, GFP_NOFS from filesystem
 > > writeout code and GFP_NOIO from block writeout code (and never doing
 > > in_interrupt()?GFP_ATOMIC:GFP_KERNEL !)
 > 
 > it strikes me that that latter part is starting to go beyond the scope
 > of simple coding style aesthetics and getting into actual coding
 > distinctions.  would that really be appropriate for the CodingStyle
 > doc?  i'm just asking.

Adding a separate 'good practices' doc wouldn't be a bad idea.

		Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?
    • From: "Robert P. J. Day" <[email protected]>
  • Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?
    • From: Arjan van de Ven <[email protected]>
  • Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?
    • From: "Robert P. J. Day" <[email protected]>

• Prev by Date: Re: bluetooth memory corruption (was Re: ext3-related crash in 2.6.20-rc1)
• Next by Date: Re: [PATCH] Consolidate default sched_clock()
• Previous by thread: Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?
• Next by thread: Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]