I will post the updated diff as a separate follow up.
Pierre Ossman wrote:
>
> When you have a commit message larger than the patch, you know there is
> something wrong. ;)
>
> Please skip the part about MMC at least.
Heh. I forget that you don't want to manually alter the email. Will do.
>
> Actually, the way the spec describes version 2.0 of the CSD leaves my
> stomach a bit upset. I think we will find cards that put bogus values in
> the fields, expecting most hosts to use the well defined values. So I'd
> prefer a switch statement here, where csd_struct == 1 results in hard
> coded values for many fields.
I'm less pessimistic than you about this, but I have no problems with
hard-coding.
>> + cmd.opcode = SD_SEND_IF_COND;
>>
>
> Put this in mmc_setup() with the rest of the initialisation. Hiding in
> here just confuses things.
Done. I thought we needed it before both SD_APP_SEND_OP_COND calls but
it's only needed before the second one so I've moved it inline into
mmc_setup.
> Also, please add a comment about why you manipulate the ocr.
Done.
>
> Wrong. R7 is defined as MMC_RSP_PRESENT|MMC_RSP_CRC|MMC_RSP_OPCODE.
>
> (So is R6 btw, wonder why that is...)
Ah - I knew they were both the same so I made R7 match R6. :-)
I've added OPCODE to both.
Thanks,
--phil
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
