Re: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers

Hi!

> Arch-neutral GPIO calls for PXA.
> 
> From: Philipp Zabel <[email protected]>

Missing s-o-b?


> +static inline int gpio_direction_input(unsigned gpio)
> +{
> +	if (gpio > PXA_LAST_GPIO)
> +		return -EINVAL;
> +	pxa_gpio_mode(gpio | GPIO_IN);
> +}

Missing return 0?

> +static inline int gpio_direction_output(unsigned gpio)
> +{
> +	if (gpio > PXA_LAST_GPIO)
> +		return -EINVAL;
> +	pxa_gpio_mode(gpio | GPIO_OUT);
> +}
> +

And here?

						Pavel
-- 
Thanks for all the (sleeping) penguins.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers
    • From: David Brownell <[email protected]>

• References:
  • [patch/rfc 2.6.19-rc5] arch-neutral GPIO calls
    • From: David Brownell <[email protected]>
  • [patch 2.6.20-rc1 0/6] arch-neutral GPIO calls
    • From: David Brownell <[email protected]>
  • [patch 2.6.20-rc1 4/6] PXA GPIO wrappers
    • From: David Brownell <[email protected]>

• Prev by Date: [FSAIO][PATCH 7/8] Filesystem AIO read
• Next by Date: Re: [PATCH 2.6.16.29 1/1] memory: enhance Linux swap subsystem
• Previous by thread: Re: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers
• Next by thread: Re: [patch 2.6.20-rc1 4/6] PXA GPIO wrappers
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]