Re: [PATCH] ata_piix: use piix_host_stop() in ich_pata_ops

Tejun,

On 11/12/06, Tejun Heo <[email protected]> wrote:

piix_init_one() allocates host private data which should be freed by
piix_host_stop().  ich_pata_ops wasn't converted to piix_host_stop()
while merging, leaking 4 bytes on driver detach.  Fix it.

I tried your patch last night but the leak is still reported. I need
to investigate further and put some printk's in the piix_host_stop
function to check whether the freeing really takes place.

What I can't follow is where the ata_port_info.private_data
(port_info[] or ppinfo[]) in piix_init_one gets transfered to
ata_host.private_data (the "host" argument) that piix_host_stop tries
to free.

--
Catalin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] ata_piix: use piix_host_stop() in ich_pata_ops
    • From: "Catalin Marinas" <[email protected]>

• References:
  • Possible memory leak in ata_piix.c
    • From: "Catalin Marinas" <[email protected]>
  • [PATCH] ata_piix: use piix_host_stop() in ich_pata_ops
    • From: Tejun Heo <[email protected]>

• Prev by Date: Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.
• Next by Date: Re: get device from file struct
• Previous by thread: Re: [PATCH] ata_piix: use piix_host_stop() in ich_pata_ops
• Next by thread: Re: [PATCH] ata_piix: use piix_host_stop() in ich_pata_ops
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]