Re: [PATCH] Export current_is_keventd() for libphy

Yes, I merged the code, but looking deeper at phy its clear I missed some things.

Looking into libphy's workqueue stuff, it has the following sequence:

	disable interrupts
	schedule_work()

	... time passes ...
	... workqueue routine is called ...

	enable interrupts
	handle interrupt

I really have to question if a workqueue was the best choice of direction for such a sequence. You don't want to put off handling an interrupt, with interrupts disabled, for a potentially unbounded amount of time.

Maybe the best course of action is to mark it with CONFIG_BROKEN until it gets fixed.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andy Fleming <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: "Maciej W. Rozycki" <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andrew Morton <[email protected]>

• References:
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andrew Morton <[email protected]>
  • [PATCH] Export current_is_keventd() for libphy
    • From: Ben Collins <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: "Maciej W. Rozycki" <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andy Fleming <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Roland Dreier <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: "Maciej W. Rozycki" <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Linus Torvalds <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Linus Torvalds <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: David Howells <[email protected]>
  • Re: [PATCH] Export current_is_keventd() for libphy
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: Simple OOM kill protection interface
• Next by Date: Re: [PATCH] WorkStruct: Fix spi_bitbang.h
• Previous by thread: Re: [PATCH] Export current_is_keventd() for libphy
• Next by thread: Re: [PATCH] Export current_is_keventd() for libphy
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]