Re: [patch] genapic: always use physical delivery mode on > 8 CPUs

On Tue, Nov 28, 2006 at 07:33:46AM +0100, Ingo Molnar wrote:
> -	if (clusters <= 1 && max_cluster <= 8 && cluster_cnt[0] == max_cluster)
> +	if (max_apic < 8)

Patch mostly looks good.  Instead of checking for max_apic, can we use
	cpus_weight(cpu_possible_map) <= 8

This will help where initially system booted with <= 8 cpus and hotplug
potentially can bringup more cpus later..

thanks,
suresh
	
>  		genapic = &apic_flat;
>  	else
> -		genapic = &apic_cluster;
> +force_physflat:
> +		genapic = &apic_physflat;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [patch] genapic: default to physical mode on hotplug CPU kernels
    • From: Ingo Molnar <[email protected]>

• Prev by Date: RE: Reserving a fixed physical address page of RAM.
• Next by Date: Re: [PATCH 3/6] ext2 balloc: fix off-by-one against rsv_end
• Previous by thread: [PATCH] REPORTING-BUGS: request .config file
• Next by thread: [patch] genapic: default to physical mode on hotplug CPU kernels
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]