Re: [PATCH 01/22] powerpc: convert idle_loop to use hard_irq_disable()

On Tuesday 21 November 2006 01:53, Benjamin Herrenschmidt wrote:
> +
> +       /*
> +        * We need to hard disable interrupts, but we also need to mark them
> +        * hard disabled in the PACA so that the local_irq_enable() done by
> +        * our caller upon return propertly hard enables.
> +        */
> +       hard_irq_disable();
> +       get_paca()->hard_enabled = 0;
> +

Yes, this looks good. Paul, please use this patch instead of mine.
Do we need to do the same thing for any of the other power_save functions?
IIRC, all new CPUs are supposed to use the same mechanism based on the
0x100 vector.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 01/22] powerpc: convert idle_loop to use hard_irq_disable()
    • From: Olof Johansson <[email protected]>

• References:
  • [PATCH 00/22] Cell patches for 2.6.20
    • From: Arnd Bergmann <[email protected]>
  • [PATCH 01/22] powerpc: convert idle_loop to use hard_irq_disable()
    • From: Arnd Bergmann <[email protected]>
  • Re: [PATCH 01/22] powerpc: convert idle_loop to use hard_irq_disable()
    • From: Benjamin Herrenschmidt <[email protected]>

• Prev by Date: Re: [take24 0/6] kevent: Generic event handling mechanism.
• Next by Date: Re: [PATCH 0/4] WorkStruct: Shrink work_struct by two thirds
• Previous by thread: Re: [PATCH 01/22] powerpc: convert idle_loop to use hard_irq_disable()
• Next by thread: Re: [PATCH 01/22] powerpc: convert idle_loop to use hard_irq_disable()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]