On Saturday 11 November 2006 8:06 am, Adrian Bunk wrote:
> The Coverity checker spotted the following NULL dereference of "skb" in
> drivers/usb/gadget/ether.c:
I don't see such a dereference. As usual, free(NULL) is legit.
Is this another case of bogus reports from Coverity? I still need to
revert a bug in the EHCI debug code caused by someone "fixing" it
because Coverity doesn't understand unions...
> <-- snip -->
>
> ...
> static int
> rx_submit (struct eth_dev *dev, struct usb_request *req, gfp_t gfp_flags)
> {
> struct sk_buff *skb;
> int retval = -ENOMEM;
> ...
> if ((skb = alloc_skb (size + NET_IP_ALIGN, gfp_flags)) == 0) {
> DEBUG (dev, "no rx skb\n");
> goto enomem;
> }
> ...
> enomem:
> defer_kevent (dev, WORK_RX_MEMORY);
> if (retval) {
> DEBUG (dev, "rx submit --> %d\n", retval);
> dev_kfree_skb_any (skb);
> ...
>
> <-- snip -->
>
> cu
> Adrian
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
