[RESEND PATCHSET] direct-io: unify asyn/sync completion paths and fix completion bugs

[forgot to include lkml, resending.  sorry ppl.]

Hello, Zach Brown, all.

Chul-Woong Yang of Aratech reported kernel oops after failed aio
(partially mapped request) on 2.6.19-rc4 and I spent three days
chasing the bug and hacking direct-io only to find out that there are
pending patches in -mm.

Oh, well.. As my patches are almost ready now, I'm posting it, for
cross-check if nothing else.  The biggest difference between your fix
and mine is that instead of merging waiting code, I just unified whole
completion paths.  ie. Sync requests are handled exactly the same as
async requests.  They are pre-dirtied, completed from bio completion
callback and redirtied from bio_dirty_work if necessary.  That
simplified the code a lot and made it humanly readable. :-)

The only concern is possible performance impact for sync DIOs due to
the change in how dirtying is done.  As it's done per-bio, the chance
of being written back between pre-issue dirtying and post-completion
checking should be pretty slim, so I don't think it would have any
noticeable effect.  Async DIOs have been handled that way after all.

I reshuffled things a bit just before finding out your patch and
didn't test it thoroughly after that, but it should be enough to get
the idea.

Arghh... The lesson here is... check -mm before starting hacking
unfamiliar code.  I'm back to libata now.

Thanks.

--
tejun


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH 5/5] direct-io: fix double completion on partially valid async requests
    • From: Tejun Heo <[email protected]>
  • [PATCH 4/5] direct-io: unify sync and async completion paths
    • From: Tejun Heo <[email protected]>
  • [PATCH 3/5] direct-io: factor out dio_determine_result()
    • From: Tejun Heo <[email protected]>
  • [PATCH 2/5] direct-io: fix dio_complete() errno passing in sync completion path
    • From: Tejun Heo <[email protected]>
  • [PATCH 1/5] direct-io: fix page_errors handling
    • From: Tejun Heo <[email protected]>

• Prev by Date: [PATCH 2/5] direct-io: fix dio_complete() errno passing in sync completion path
• Next by Date: [PATCH 3/5] direct-io: factor out dio_determine_result()
• Previous by thread: [PATCH 2/2] Use dev_sysdata for ACPI and remove firmware_data
• Next by thread: [PATCH 1/5] direct-io: fix page_errors handling
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]