Re: [PATCH 6/7] Add APIC accessors to paravirt-ops.

>
>  /* nop stub */
>  static void native_nop(void)
> @@ -382,6 +384,26 @@ static fastcall void native_io_delay(voi
>  	asm volatile("outb %al,$0x80");
>  }
>
> +#ifdef CONFIG_X86_LOCAL_APIC

It would be nicer if you renamed the functions in apic.h to native_apic_*
and then do

#ifdef CONFIG_PARAVIRT
#include <asm/paravirt.h>
#else
#define apic_read native_apic_read
...
#endif

This way we wouldn't get that much duplication.

This might apply to at least some of the other paravirt ops too.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 6/7] Add APIC accessors to paravirt-ops.
    • From: Rusty Russell <[email protected]>

• References:
  • [PATCH 0/7] x86 paravirtualization infrastructure
    • From: Chris Wright <[email protected]>
  • [PATCH 6/7] Add APIC accessors to paravirt-ops.
    • From: Chris Wright <[email protected]>

• Prev by Date: Re: [PATCH 1/7] header and stubs for paravirtualizing critical operations
• Next by Date: Re: [PATCH 3/7] More generic paravirtualization entry point.
• Previous by thread: [PATCH 6/7] Add APIC accessors to paravirt-ops.
• Next by thread: Re: [PATCH 6/7] Add APIC accessors to paravirt-ops.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]