Re: [PATCH 2.6.19-rc3] VFS: missing unused dentry in prune_dcache()

Vasily Averin <[email protected]> wrote:

> +		/* Inserting dentry to tail of the list leads to cycle */
> + 		list_add(&dentry->d_lru, &dentry_unused);
> +		dentry_stat.nr_unused++;

I'd phrase that comment differently: "Insert dentry at the head of the list as
inserting at the tail leads to a cycle".

But other than that:

Acked-By: David Howells <[email protected]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 2.6.19-rc3] VFS: missing unused dentry in prune_dcache()
    • From: Vasily Averin <[email protected]>
  • Re: [Q] missing unused dentry in prune_dcache()?
    • From: Vasily Averin <[email protected]>
  • [Q] missing unused dentry in prune_dcache()?
    • From: Vasily Averin <[email protected]>
  • Re: [Q] missing unused dentry in prune_dcache()?
    • From: David Howells <[email protected]>
  • Re: [Q] missing unused dentry in prune_dcache()?
    • From: David Howells <[email protected]>

• Prev by Date: Re: incorrect taint of ndiswrapper
• Next by Date: Re: [Q] ide cdrom in native mode leads to irq storm?
• Previous by thread: [PATCH 2.6.19-rc3] VFS: missing unused dentry in prune_dcache()
• Next by thread: Re: [Q] missing unused dentry in prune_dcache()?
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]