Re: [PATCH] Fix generic WARN_ON message

* Jeremy Fitzhardinge <[email protected]> wrote:

> A warning is a warning, not a BUG.

> -		printk("BUG: warning at %s:%d/%s()\n", __FILE__,	\
> +		printk("WARNING at %s:%d %s()\n", __FILE__,	\

i'm not really happy about this change.

Firstly, most WARN_ON()s are /bugs/, not warnings ... If it's a real 
warning, a KERN_INFO printk should be done.

Secondly, the reason i changed it to the 'BUG: ...' format is that i 
tried to make it easier for automated tools (and for users) to figure 
out that a kernel bug happened.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Fix generic WARN_ON message
    • From: Pavel Machek <[email protected]>
  • Re: [PATCH] Fix generic WARN_ON message
    • From: Jeremy Fitzhardinge <[email protected]>

• References:
  • [PATCH] Fix generic WARN_ON message
    • From: Jeremy Fitzhardinge <[email protected]>

• Prev by Date: Re: [GIT PATCH] USB fixes and drivers for 2.6.18-rc2
• Next by Date: Re: readjust comments of task_timeslice for kernel doc
• Previous by thread: [PATCH] Fix generic WARN_ON message
• Next by thread: Re: [PATCH] Fix generic WARN_ON message
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]