Re: [PATCH] libsas: support NCQ for SATA disks

Brian King wrote:

This doesn't look like the right fix for the oops you were seeing. The
SAS usage of libata has ap->scsi_host as NULL, which indicates that
libata does not own the associated scsi_host. I'm concerned you may
have broken some other code path by making this change. I think the correct
fix may require removing the dependence of ap->scsi_host from

ata_dev_config_ncq.

Yep.  I had already mentioned this on IRC.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] libsas: support NCQ for SATA disks
    • From: James Bottomley <[email protected]>

• References:
  • [PATCH] libsas: support NCQ for SATA disks
    • From: "Darrick J. Wong" <[email protected]>
  • Re: [PATCH] libsas: support NCQ for SATA disks
    • From: Brian King <[email protected]>

• Prev by Date: 2.6.19-rc2 has ld error for ppc64
• Next by Date: [PATCH] file: kill unnecessary timer in fdtable_defer
• Previous by thread: Re: [PATCH] libsas: support NCQ for SATA disks
• Next by thread: Re: [PATCH] libsas: support NCQ for SATA disks
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]