On Mon, Oct 16, 2006 at 01:39:03AM +0200, Marcel Holtmann wrote:
> > @@ -205,7 +205,7 @@ #define l2cap_pi(sk) ((struct l2cap_pinf
> >
> > struct l2cap_pinfo {
> > struct bt_sock bt;
> > - __u16 psm;
> > + __le16 psm;
> > __u16 dcid;
> > __u16 scid;
> >
> > @@ -221,7 +221,7 @@ struct l2cap_pinfo {
> >
> > __u8 ident;
> >
> > - __u16 sport;
> > + __le16 sport;
> >
> > struct l2cap_conn *conn;
> > struct sock *next_c;
>
> These are internal. We should have to annotate them. They should store
> it in host order. If not, than that is the problem.
BTW, I would leave ->psm is wire order; we compare it to ->l2_psm from
sockaddr_l2 a lot, so putting a conversion there looks odd.
Note that we do pass ->ls_psm to __l2cap_sock_by_addr(), so I'm not sure
if I like the idea of host-endian ->sport; we would need to slap a conversion
there as well.
See also
bacpy(&bt_sk(sk)->src, &la->l2_bdaddr);
l2cap_pi(sk)->psm = la->l2_psm;
l2cap_pi(sk)->sport = la->l2_psm;
sk->sk_state = BT_BOUND;
for other place where net-endian gets there.
Are you sure that you want both to be switched to host-endian?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
