Re: [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal

On Fri, 2006-10-13 at 17:10 +0530, Amol Lad wrote:
> Removed save_flags()/cli()/sti() and used (light weight) spin locks

Hi,

I applaud removing such legacy-should-be-dead-by-now functions; however,
I'm not entirely sure your conversion is correct. While you convert all
places that do cli/sti with locks.... you do not seem to be adding the
locks to the places that the cli/sti pairs protected against (the IRQ
handlers).... so it looks like your conversion is incomplete ;(

Greetings,
    Arjan van de Ven

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal
    • From: Amol Lad <[email protected]>

• References:
  • [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal
    • From: Amol Lad <[email protected]>

• Prev by Date: [PATCH 1 of 2] Stackfs: Introduce stackfs_copy_{attr,inode}_*
• Next by Date: Re: Hardware bug or kernel bug?
• Previous by thread: [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal
• Next by thread: Re: [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]