tty_driver->ttys association

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

I found this construction in the kernel:
static struct tty_driver *my_ttydriver;
static struct tty_struct *my_tty[PORTS + 1];
static struct termios *my_termios[PORTS + 1];
static struct termios *my_termios_locked[PORTS + 1];

...(alloc+set_op+...)
my_ttydriver->flags = TTY_DRIVER_REAL_RAW|TTY_DRIVER_DYNAMIC_DEV;
my_ttydriver->ttys = my_tty;
my_ttydriver->termios = my_termios;
my_ttydriver->termios_locked = my_termios_locked;
tty_register_driver(my_ttydriver);

The association is completely useless due to
if (p) {
    driver->ttys = (struct tty_struct **)p;
    driver->termios = (struct termios **)(p + driver->num);
    driver->termios_locked = (struct termios **)(p + driver->num * 2);
} else {
    driver->ttys = NULL;
    driver->termios = NULL;
    driver->termios_locked = NULL;
}

in tty_register_driver, isn't it? Can we save some memory?

thanks,
--
http://www.fi.muni.cz/~xslaby/            Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux