On Tue, 10 Oct 2006, Andreas Schwab wrote:
> "Robert P. J. Day" <[email protected]> writes:
>
> > Remove the minimally-useful definition of IXGB_DBG() and have
> > ixgb_main.c call pr_debug() directly.
> >
> > Signed-off-by: Robert P. J. Day <[email protected]>
> > ---
> > diff --git a/drivers/net/ixgb/ixgb.h b/drivers/net/ixgb/ixgb.h
> > index 50ffe90..fb9fde5 100644
> > --- a/drivers/net/ixgb/ixgb.h
> > +++ b/drivers/net/ixgb/ixgb.h
> > @@ -77,12 +77,6 @@ #include "ixgb_hw.h"
> > #include "ixgb_ee.h"
> > #include "ixgb_ids.h"
> >
> > -#ifdef _DEBUG_DRIVER_
> > -#define IXGB_DBG(args...) printk(KERN_DEBUG "ixgb: " args)
> ^^^^^^^^
> > -#else
> > -#define IXGB_DBG(args...)
> > -#endif
> > -
> > #define PFX "ixgb: "
> > #define DPRINTK(nlevel, klevel, fmt, args...) \
> > (void)((NETIF_MSG_##nlevel & adapter->msg_enable) && \
> > diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c
> > index e09f575..d063e84 100644
> > --- a/drivers/net/ixgb/ixgb_main.c
> > +++ b/drivers/net/ixgb/ixgb_main.c
> > @@ -1948,7 +1948,7 @@ #endif
> >
> > /* All receives must fit into a single buffer */
> >
> > - IXGB_DBG("Receive packet consumed multiple buffers "
> > + pr_debug("Receive packet consumed multiple buffers "
>
> Would perhaps be useful to retain the "ixgb:" prefix.
crap, you're right. my bad. back into the breech ... argh. that's
what happens when there's only decaf left in the house.
rday
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
