Re: [PATCH] Introduce vfs_listxattr

[Al Viro <viro@ftp.linux.org.uk>]

On Mon, Oct 09, 2006 at 01:33:32PM -0700, Andrew Morton wrote:
> On Mon, 9 Oct 2006 16:10:48 -0400
> Josef Sipek <jsipek@fsl.cs.sunysb.edu> wrote:
> 
> > This patch moves code out of fs/xattr.c:listxattr into a new function -
> > vfs_listxattr. The code for vfs_listxattr was originally submitted by Bill
> > Nottingham <notting@redhat.com> to Unionfs.
> 
> That tells us what the patch does.  In general, please be sure to also tell
> us *why* you prepared a patch.
> 
> Does this patch allow unionfs to be loaded into an otherwise unpatched
> kernel.org kernel?  If so, that seems to be a good reason for including
> this patch into the mainline kernel.

Generally I'd say that it makes sense.  Anything that wants to
access the method in question would either have to play with
set_fs() or open-code it; neither is good.

It makes sense to localize calls of a method when we have pretty
much mandatory framing for it (security_... stuff).

So the only question is whether it makes sense for anything other
than syscall itself to access the method in question.  AFAICS,
the answer's yes...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/