Re: [PATCH] fs/partitions/check: add sysfs error handling

Al Viro wrote:

On Wed, Oct 04, 2006 at 08:19:00AM -0400, Jeff Garzik wrote:

Handle errors thrown in disk_sysfs_symlinks(), and propagate back
to caller.

The callers and associated functions don't do a real good job
of handling kobject errors anyway (add_partition, register_disk,
rescan_partitions), so this should do until something better comes
along.

I'm not sure that failure to create these symlinks should be fatal,
to be honest...

Fair enough, though FWIW the failure is almost always -EFAULT or -ENOMEM, i.e. -ESYSTEMINTROUBLE...

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] fs/partitions/check: add sysfs error handling
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH] fs/partitions/check: add sysfs error handling
    • From: Al Viro <[email protected]>

• Prev by Date: Re: [RFC] PATCH to fix rescan_partitions to return errors properly
• Next by Date: [PATCH] Cache miss eliminating in WARN_ON_ONCE
• Previous by thread: Re: [PATCH] fs/partitions/check: add sysfs error handling
• Next by thread: [PATCH] drivers/base: error handling fixes
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]