On Tue, Sep 19, 2006 at 03:24:46PM +0900, Tejun Heo wrote: > Jeff Garzik wrote: > >I don't really like this port_tbl approach. I think it complicates > >things too much. > > > >Direct indexing should be fine. For the non-linear case, just make sure > >the non-existent ports are always dummy ports. If the driver directly > >references a port we know isn't there, that's just an AHCI bug to be > >fixed... > > I thought about that too, but it will end up with ata1-6 with dummy 3 > and 4 while the BIOS shows continuous 4 ports. I wanted avoid this > discrepancy as it could cause confusion to users. > > The other option is adding pp->port_idx to record hw port index. It > does make the code a bit simpler. What do you think about this? *bump* Jeff - any opinions on Tejun's or my last posts on this, or do you want to see some code for the idea. -- Robin Hugh Johnson E-Mail : [email protected] GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85
Attachment:
pgpjJlnKq0sNB.pgp
Description: PGP signature
- References:
- 2.6.18-rc7-git1: AHCI not seeing devices on ICH8 mobo (DG965RY)
- From: "Robin H. Johnson" <[email protected]>
- Re: 2.6.18-rc7-git1: AHCI not seeing devices on ICH8 mobo (DG965RY)
- From: Jeff Garzik <[email protected]>
- Re: 2.6.18-rc7-git1: AHCI not seeing devices on ICH8 mobo (DG965RY)
- From: "Robin H. Johnson" <[email protected]>
- Re: 2.6.18-rc7-git1: AHCI not seeing devices on ICH8 mobo (DG965RY)
- From: "Robin H. Johnson" <[email protected]>
- Re: 2.6.18-rc7-git1: AHCI not seeing devices on ICH8 mobo (DG965RY)
- From: "Robin H. Johnson" <[email protected]>
- Re: 2.6.18-rc7-git1: AHCI not seeing devices on ICH8 mobo (DG965RY)
- From: Tejun Heo <[email protected]>
- Re: 2.6.18-rc7-git1: AHCI not seeing devices on ICH8 mobo (DG965RY)
- From: Jeff Garzik <[email protected]>
- Re: 2.6.18-rc7-git1: AHCI not seeing devices on ICH8 mobo (DG965RY)
- From: Tejun Heo <[email protected]>
- 2.6.18-rc7-git1: AHCI not seeing devices on ICH8 mobo (DG965RY)
- Prev by Date: Re: [PATCH] Linux Kernel Markers 0.11 for 2.6.17
- Next by Date: Re: [PATCH -mm] console: console_drivers not initialized
- Previous by thread: Re: 2.6.18-rc7-git1: AHCI not seeing devices on ICH8 mobo (DG965RY)
- Next by thread: Re: 2.6.18-rc7-git1: AHCI not seeing devices on ICH8 mobo (DG965RY)
- Index(es):
 |