[PATCH] wrong thing iounmapped (qla3xxx)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ql3xxx_probe() does ioremap and stores result in
->mem_map_registers.  On failure exit it does iounmap()
of the same thing.  OTOH, ql3xxx_remove() does iounmap()
of ->mmap_virt_base which is (a) never assigned and
(b) never used other than in that iounmap() call.

Signed-off-by: Al Viro <[email protected]>
---
 drivers/net/qla3xxx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c
index c184cd8..1574718 100644
--- a/drivers/net/qla3xxx.c
+++ b/drivers/net/qla3xxx.c
@@ -3508,7 +3508,7 @@ static void __devexit ql3xxx_remove(stru
 		qdev->workqueue = NULL;
 	}
 
-	iounmap(qdev->mmap_virt_base);
+	iounmap(qdev->mem_map_registers);
 	pci_release_regions(pdev);
 	pci_set_drvdata(pdev, NULL);
 	free_netdev(ndev);
-- 
1.4.2.GIT

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux