Re: [PATCH 1/4] Blackfin: arch patch for 2.6.18

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/24/06, Randy Dunlap <[email protected]> wrote:
On Sun, 24 Sep 2006 11:35:31 +0800 Aubrey wrote:

> On 9/23/06, Arnd Bergmann <[email protected]> wrote:
> > > +static uint32_t reloc_stack_operate(unsigned int oper, struct module *mod)
> > > +{
> > > +     uint32_t value;
> > > +     switch (oper) {
> > > +     case R_add:
> > > +             {
> > > +                     value =
> > > +                         reloc_stack[reloc_stack_tos - 2] +
> > > +                         reloc_stack[reloc_stack_tos - 1];
> > > +                     reloc_stack_tos -= 2;
> > > +                     break;
> > > +             }
> >
> > no need for the curly braces here and below
>
> Hmm, but we need one line < 80 columns, don't we?

Yes (preferably), but:
The braces for case R_add above simply aren't needed at all.
And after they are removed, you can indent the remaining code
one less tab stop.

Yeah, the braces for case should be removed. Done.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux