Re: [PATCH 3/3] delay: add generic udelay(), mdelay() and ssleep()

On Fri, Sep 22, 2006 at 10:00:33AM +0200, Denis Vlasenko wrote:
> * __const_udelay for all arches is removed or renamed to
> ? __const_delay (it did not do microsecond delays anyway)

You never explained this properly - in fact I think your logic is
reversed.  Let me remind you of my reply (which afaics never got
a response):

On Wed, Aug 23, 2006 a 09:14:52AM +0100, Russell King wrote:
> On Wed, Aug 23, 2006 at 07:50:24AM +0200, Denis Vlasenko wrote:
> > On Tuesday 22 August 2006 18:55, Russell King wrote:
> > > Please keep a "const" version in ARM.  Thanks.
> >
> > Are you talking about this hunk? Why do you want to keep it?
> >
> > I mean, without it udelay(n) will become slower by the time
> > needed for one extra multiply. So we will have maybe
> > udelay(n) ==> udelay(n+0.1).
> 
> Why do you think that?  With the constant version, the additional
> unnecessary multiply is optimised away by the compiler (since
> constant * constant = constant), so it's actually slightly faster,
> not sligntly slower as you seem to think.
> 
> Since the multiply is pure overhead, it's better to get rid of it.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 3/3] delay: add generic udelay(), mdelay() and ssleep()
    • From: Denis Vlasenko <[email protected]>

• References:
  • [PATCH 1/3] delay: s/#include <asm/delay.h>/#include <linux/delay.h>/
    • From: Denis Vlasenko <[email protected]>
  • [PATCH 2/3] delay: remove references to MAX_UDELAY_MS; fix comment
    • From: Denis Vlasenko <[email protected]>
  • [PATCH 3/3] delay: add generic udelay(), mdelay() and ssleep()
    • From: Denis Vlasenko <[email protected]>

• Prev by Date: [3/9] driver core fixes: sysfs_create_link() retval check in class.c
• Next by Date: [8/9] driver core fixes: device_create_file() retval check in dmapool.c
• Previous by thread: [PATCH 3/3] delay: add generic udelay(), mdelay() and ssleep()
• Next by thread: Re: [PATCH 3/3] delay: add generic udelay(), mdelay() and ssleep()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]