Re: [PATCH 4/4] therm_throt: Add a cumulative thermal throttle event counter.

> +	preempt_disable();         /* CPU hotplug */
> +	for_each_online_cpu(cpu) {
> +		/* connect live CPUs to sysfs */
> +		thermal_throttle_add_dev(get_cpu_sysdev(cpu));
> +	}
> +	preempt_enable();

There was still one problem in there: sysfs_create_group can 
sleep and that's not ok with preemption disabled.

I changed it to register the notifier first and do the necessary
locking in there using a private lock (that the new akpm-recommended(tm)
way to do this) 

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 0/4 v2] therm_throt: Refactor thermal throttle processing, and keep a total count of events.
    • From: Dmitriy Zavin <[email protected]>
  • [PATCH 3/4] therm_throt: Make the jiffies compares use the 64bit safe macros.
    • From: Dmitriy Zavin <[email protected]>
  • [PATCH 4/4] therm_throt: Add a cumulative thermal throttle event counter.
    • From: Dmitriy Zavin <[email protected]>

• Prev by Date: Re: [PATCH 0/4 v2] therm_throt: Refactor thermal throttle processing, and keep a total count of events.
• Next by Date: Re: [PATCH 1/4] x86_64/i386 therm mce: Refactor thermal throttle processing
• Previous by thread: [PATCH 4/4] therm_throt: Add a cumulative thermal throttle event counter.
• Next by thread: Re: [PATCH 1/4] x86_64/i386 therm mce: Refactor thermal throttle processing
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]