Re: [PATCH 1/2] [MMC] Driver for TI FlashMedia card reader - source

On Wed, Sep 20, 2006 at 09:28:05AM +0300, Pekka Enberg wrote:
 > On 9/20/06, Andrew Morton <[email protected]> wrote:
 > > Trivia:
 > 
 > [snip]
 > 
 > More trivia:
 > 
 >   - Unnecessary casts for void pointers
 >   - Assignment in if statement expression

also

+#include <linux/config.h>
+#include <linux/module.h>
+#include <linux/kernel.h>

Some unnecessary includes there. (config.h & kernel.h are auto-included)

	Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/2] [MMC] Driver for TI FlashMedia card reader - source
    • From: Alexey Dobriyan <[email protected]>

• References:
  • [PATCH 1/2] [MMC] Driver for TI FlashMedia card reader - source
    • From: Alex Dubov <[email protected]>
  • Re: [PATCH 1/2] [MMC] Driver for TI FlashMedia card reader - source
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 1/2] [MMC] Driver for TI FlashMedia card reader - source
    • From: "Pekka Enberg" <[email protected]>

• Prev by Date: Poor scheduling when not loaded at 100% (Was: [PATCH] sched.c: Be a bit more conservative in SMP)
• Next by Date: Re: [PATCH] Linux Kernel Markers 0.2 for Linux 2.6.17
• Previous by thread: Re: [PATCH 1/2] [MMC] Driver for TI FlashMedia card reader - source
• Next by thread: Re: [PATCH 1/2] [MMC] Driver for TI FlashMedia card reader - source
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]