Re: [PATCH 4/6] Implement a general log2 facility in the kernel

On Wed, Sep 13, 2006 at 02:03:00PM +0100, David Howells wrote:
> From: David Howells <[email protected]>
> 
> This facility provides three entry points:
> 
> 	log2()		Log base 2 of u32
> 	ll_log2()	Log base 2 of u64
> 	long_log2()	Log base 2 of unsigned long

The names are rather counter-intuitive. "ll" sounds like "long long", so
why does it opearte on *unsigned* 64-bit?  Ditto for "long_log2()".
Perhaps they should be log2_u32(), log2_u64(), etc.

Even better if someone can come up with the right pre-processor magic
using sizeof/typeof so that you could just use "log2(any type)"


-Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 1/6] FRV: Fix fls() to handle bit 31 being set correctly
    • From: David Howells <[email protected]>
  • [PATCH 4/6] Implement a general log2 facility in the kernel
    • From: David Howells <[email protected]>

• Prev by Date: [PATCH] FRV: Fix header exports
• Next by Date: Re: [PATCH] make ipv4 multicast packets only get delivered to sockets that are joined to group
• Previous by thread: [PATCH 4/6] Implement a general log2 facility in the kernel
• Next by thread: Re: [PATCH 4/6] Implement a general log2 facility in the kernel
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]