On Thu, 7 Sep 2006 15:51:05 +0200
Ingo Molnar <[email protected]> wrote:
>
> * Andrew Morton <[email protected]> wrote:
>
> > This is due to a gruesome hack (IMO) in the genirq code
> > (handle_irq_name()) which magically "knows" about the various types of
> > IRQ handler, but doesn't know about the MSI ones. It should be
> > converted to a field in irq_desc, or a callback or something.
>
> a field in irq_desc[] was frowned upon during initial genirq review, due
> to size reasons, so i removed it and replaced it with the hack.
irq_desc[] is already in the hundred-byte range. I'm a bit surprised that
another char* is worth sweating over.
What's in irq_chip.name, btw? "name for /proc/interrupts". hmm.
> > I already had a whine about this then forgot about it, but it seems that
> > code can't be changed by whining at it ;)
>
> ;)
>
> i think we could add a 'register handler name' API (or extend
> set_irq_handler() API), to pass in the name of handlers, and store it in
> a small array (instead of embedding it in irq_desc)? handle_irq_name()
> is not performance-critical.
spose so.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
