Re: [PATCH 22 of 23] IB/ipath - print warning if LID not acquired within one minute

• To: "Bryan O'Sullivan" <[email protected]>
• Subject: Re: [PATCH 22 of 23] IB/ipath - print warning if LID not acquired within one minute
• From: Roland Dreier <[email protected]>
• Date: Fri, 25 Aug 2006 12:35:06 -0700
• Authentication-results: sj-dkim-5.cisco.com; [email protected]; dkim=pass ( sig from cisco.com verified; );
• Cc: [email protected], [email protected]
• Dkim-signature: a=rsa-sha1; q=dns; l=557; t=1156534509; x=1157398509; c=relaxed/simple; s=sjdkim5002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; [email protected]; z=From:Roland=20Dreier=20<[email protected]> |Subject:Re=3A=20[PATCH=2022=20of=2023]=20IB/ipath=20-=20print=20warning=20if=20L ID=20not=20acquired=20within=20one=20minute; X=v=3Dcisco.com=3B=20h=3DL+S3P58XqfSfJGwMRDwQ91BO0eo=3D; b=AYrEp7fF1jjliLGFp1JX3yHRHFrQi52hi1M3dvllWJCBhXkRKmn4UjDvFLwqZuQF2GrtJn+g lK1/L3pq/NqisQEurdjc4z9EdihyouJVbuhdbsRpFdiLGYro3lEP9kij;
• In-reply-to: <[email protected]> (Bryan O'Sullivan's message of "Fri, 25 Aug 2006 11:24:47 -0700")
• References: <[email protected]>
• Sender: [email protected]
• User-agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.4.18 (linux)

1) What makes ipath special so that we want this warning for ipath
devices but not other IB hardware?  If this warning is actually
useful, then I think it would make more sense to start a timer when
any IB device is added, and warn if ports with a physical link don't
become active after the timeout time.  But I'm having a hard time
seeing why we want this message in the kernel log.

2) You do cancel_delayed_work() but not flush_scheduled_work(), so
it's possible for your timeout function to be running after the module
text is gone.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [openib-general] [PATCH 22 of 23] IB/ipath - print warning if LID not acquired within one minute
    • From: Robert Walsh <[email protected]>

• References:
  • [PATCH 22 of 23] IB/ipath - print warning if LID not acquired within one minute
    • From: "Bryan O'Sullivan" <[email protected]>

• Prev by Date: Re: Serial custom speed deprecated?
• Next by Date: Re: [RFC] maximum latency tracking infrastructure (version 2)
• Previous by thread: [PATCH 22 of 23] IB/ipath - print warning if LID not acquired within one minute
• Next by thread: Re: [openib-general] [PATCH 22 of 23] IB/ipath - print warning if LID not acquired within one minute
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]