Re: [PATCH] loop.c: kernel_thread() retval check

On 8/20/06, Solar Designer <[email protected]> wrote:

You need to make sure that the cleanup code added with the patch matches
the loop device initialization preceding the kernel_thread() call.  You
should not blindly take the cleanup code out of the 2.4 patch and apply
it to 2.6 - it might not be correct for 2.6.

Yes, I already had that in mind, but thanks for the worry, anyway.

No.  But you won't be able to reproduce this with strace on 2.6 since
2.6's kernel_thread() uses CLONE_UNTRACED instead of failing on ptrace.
You'll probably need to temporarily replace the kernel_thread() call in
loop.c with -EAGAIN to comfortably test your cleanup code without
forcing the system to run out of resources.

Thanks for the tip. I'll see what I can do. :)

Cheers,

   Julio Auto
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] loop.c: kernel_thread() retval check
    • From: Solar Designer <[email protected]>
  • Re: [PATCH] loop.c: kernel_thread() retval check
    • From: Alan Cox <[email protected]>
  • Re: [PATCH] loop.c: kernel_thread() retval check
    • From: Solar Designer <[email protected]>
  • Re: [PATCH] loop.c: kernel_thread() retval check
    • From: Alan Cox <[email protected]>
  • Re: [PATCH] loop.c: kernel_thread() retval check
    • From: Willy Tarreau <[email protected]>
  • Re: [PATCH] loop.c: kernel_thread() retval check
    • From: "Julio Auto" <[email protected]>
  • Re: [PATCH] loop.c: kernel_thread() retval check
    • From: Solar Designer <[email protected]>

• Prev by Date: Re: [ckrm-tech] [PATCH 4/7] UBC: syscalls (user interface)
• Next by Date: [GIT PATCH] ACPI for 2.6.18-rc4
• Previous by thread: Re: [PATCH] loop.c: kernel_thread() retval check
• Next by thread: [PATCH] cit_encrypt_iv/cit_decrypt_iv for ECB mode
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]